Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR] Adjust endpoints for ES 8.0 snapshot API changes #39533

Merged
merged 1 commit into from
Jun 25, 2019
Merged

[SR] Adjust endpoints for ES 8.0 snapshot API changes #39533

merged 1 commit into from
Jun 25, 2019

Conversation

jen-huang
Copy link
Contributor

@jen-huang jen-huang commented Jun 24, 2019 •
edited
Loading

Adjust snapshot and repositories endpoint to account for changes in the response of ES APIs: elastic/elasticsearch#42090

When running a recent 8.0 snapshot version of ES and Kibana without this PR, parts of SR breaks, most notably the list of snapshots does not load and inaccurately shows a message about errors with repositories. This PR fixes that and other places in SR where snapshot information is retrieved.

(cc @cjcenizal since you ran into these issues first!)

Note: The ES API changes are breaking and only target 8.0, so this PR will be the same and will NOT be backported.

@jen-huang jen-huang added chore non-issue Indicates to automation that a pull request should not appear in the release notes v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI labels Jun 24, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@jen-huang jen-huang changed the title [SR] Adjust endpoints for ES 8.0 API changes [SR] Adjust endpoints for ES 8.0 snapshot API changes Jun 24, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@jen-huang
Copy link
Contributor Author

Failing on unrelated dashboard test.

@jen-huang
Copy link
Contributor Author

Retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

alisonelizabeth
alisonelizabeth approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM.

@jen-huang jen-huang merged commit 0b7f0c5 into elastic:master Jun 25, 2019
@jen-huang jen-huang deleted the fix/sr-es-8.0 branch June 25, 2019 15:10
@alisonelizabeth alisonelizabeth mentioned this pull request Mar 18, 2020
Merged
@cjcenizal cjcenizal mentioned this pull request Mar 24, 2020
Closed
@alisonelizabeth alisonelizabeth mentioned this pull request Sep 30, 2020
Closed
@alisonelizabeth alisonelizabeth mentioned this pull request Mar 30, 2021
Merged
@alisonelizabeth alisonelizabeth mentioned this pull request Jun 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

Assignees
No one assigned
Labels
chore Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jen-huang @elasticmachine @alisonelizabeth